Skip to content

feat: add version command properly#321

Merged
KLongmuirHD merged 2 commits into
mainfrom
feat/add_version_command
Sep 4, 2025
Merged

feat: add version command properly#321
KLongmuirHD merged 2 commits into
mainfrom
feat/add_version_command

Conversation

@KLongmuirHD
Copy link
Copy Markdown
Contributor

@KLongmuirHD KLongmuirHD commented Sep 4, 2025

  • Fix an issue where the --version flag did not work
  • Fix an issue where the CLI would show the cleaning up spinner unnecessarily
  • Fix an issue where the CLI would hang on unknown commands

@KLongmuirHD KLongmuirHD requested a review from a team as a code owner September 4, 2025 15:03
Copy link
Copy Markdown
Contributor

@edezekiel edezekiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - except while testing this branch locally I noticed the CLI now hangs when you give it an unknown command. I checked main and that bug exists there too, so I don't request changes on this PR.

Also there are several linting errors on the branch that need fixing.

Screenshot 2025-09-04 at 10 17 34 AM

@KLongmuirHD KLongmuirHD force-pushed the feat/add_version_command branch 2 times, most recently from 4fbdbb3 to 39dbb8f Compare September 4, 2025 18:43
@KLongmuirHD
Copy link
Copy Markdown
Contributor Author

Hold on this, something's not working right

@KLongmuirHD KLongmuirHD marked this pull request as draft September 4, 2025 18:54
@KLongmuirHD KLongmuirHD force-pushed the feat/add_version_command branch from 39dbb8f to 69232a1 Compare September 4, 2025 18:58
@KLongmuirHD
Copy link
Copy Markdown
Contributor Author

okay fixed, I had set up the multiple init hooks incorrectly

@KLongmuirHD KLongmuirHD marked this pull request as ready for review September 4, 2025 18:59
@KLongmuirHD KLongmuirHD merged commit 1a22fb1 into main Sep 4, 2025
12 checks passed
@KLongmuirHD KLongmuirHD deleted the feat/add_version_command branch September 4, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants