Skip to content

feat: EOL API pagination#304

Merged
rlmestre merged 3 commits into
mainfrom
feat/pagination
Aug 18, 2025
Merged

feat: EOL API pagination#304
rlmestre merged 3 commits into
mainfrom
feat/pagination

Conversation

@rlmestre
Copy link
Copy Markdown
Contributor

Closes neverendingsupport/data-and-integrations#262

@rlmestre rlmestre requested a review from Copilot August 18, 2025 12:49
@rlmestre rlmestre requested a review from a team as a code owner August 18, 2025 12:49
Comment thread package.json Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements pagination for the EOL API to handle large reports by fetching components in pages rather than all at once. The changes include new GraphQL operations for paginated data retrieval, configuration for page size and concurrent requests, and updated mocks to support the new paginated flow.

  • Refactored EOL report creation to return only metadata and total record count
  • Added paginated fetching of report components with configurable page size and concurrent requests
  • Updated all tests and mocks to support the new two-step report creation and retrieval process

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/api/nes.client.ts Implements pagination logic with batch processing for report components
src/api/gql-operations.ts Adds new GraphQL query for paginated report retrieval
src/config/constants.ts Adds pagination configuration constants
test/api/nes.client.test.ts Updates unit tests to mock paginated API responses
e2e/scan/eol.test.ts Updates e2e tests with separate mocks for report creation and retrieval
test/service/analytics.svc.test.ts Minor test utility improvement
package.json Updates shared library dependency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/config/constants.ts Outdated
Comment thread src/config/constants.ts Outdated
Comment thread src/api/nes.client.ts
Comment thread src/api/nes.client.ts
Comment thread src/api/nes.client.ts
@rlmestre rlmestre requested a review from a team August 18, 2025 16:10
@rlmestre rlmestre merged commit e2fabac into main Aug 18, 2025
23 of 24 checks passed
@rlmestre rlmestre deleted the feat/pagination branch August 18, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants