feat: EOL API pagination#304
Merged
Merged
Conversation
aadcb19 to
62694c5
Compare
KLongmuirHD
reviewed
Aug 18, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR implements pagination for the EOL API to handle large reports by fetching components in pages rather than all at once. The changes include new GraphQL operations for paginated data retrieval, configuration for page size and concurrent requests, and updated mocks to support the new paginated flow.
- Refactored EOL report creation to return only metadata and total record count
- Added paginated fetching of report components with configurable page size and concurrent requests
- Updated all tests and mocks to support the new two-step report creation and retrieval process
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/api/nes.client.ts | Implements pagination logic with batch processing for report components |
| src/api/gql-operations.ts | Adds new GraphQL query for paginated report retrieval |
| src/config/constants.ts | Adds pagination configuration constants |
| test/api/nes.client.test.ts | Updates unit tests to mock paginated API responses |
| e2e/scan/eol.test.ts | Updates e2e tests with separate mocks for report creation and retrieval |
| test/service/analytics.svc.test.ts | Minor test utility improvement |
| package.json | Updates shared library dependency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
KLongmuirHD
reviewed
Aug 18, 2025
KLongmuirHD
approved these changes
Aug 18, 2025
edezekiel
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes neverendingsupport/data-and-integrations#262