Skip to content

feat: update logic to adhere to new EOL-API contract#290

Merged
rlmestre merged 9 commits into
mainfrom
feat/new-eol-api-contract
Aug 1, 2025
Merged

feat: update logic to adhere to new EOL-API contract#290
rlmestre merged 9 commits into
mainfrom
feat/new-eol-api-contract

Conversation

@rlmestre
Copy link
Copy Markdown
Contributor

@rlmestre rlmestre commented Jul 23, 2025

Closes neverendingsupport/data-and-integrations#128
Closes neverendingsupport/data-and-integrations#206
Closes neverendingsupport/data-and-integrations#212

@rlmestre rlmestre requested a review from Copilot July 23, 2025 17:11

This comment was marked as outdated.

@rlmestre rlmestre marked this pull request as ready for review July 25, 2025 18:13
@rlmestre rlmestre requested a review from a team as a code owner July 25, 2025 18:13
@rlmestre rlmestre requested a review from Copilot July 25, 2025 18:13

This comment was marked as outdated.

@rlmestre rlmestre force-pushed the feat/new-eol-api-contract branch from e3c1164 to 01feb58 Compare July 29, 2025 21:43
@rlmestre rlmestre requested a review from Copilot July 30, 2025 15:40
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the application to adhere to a new EOL-API contract, migrating from the old NES-specific API to a new shared EOL API contract using the @herodevs/eol-shared package.

  • Replaces custom type definitions with shared types from @herodevs/eol-shared
  • Updates GraphQL mutations and API client methods to use the new EOL report creation endpoint
  • Removes batching logic and simplifies scan submission workflow

Reviewed Changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
package.json Adds @herodevs/eol-shared dependency for shared types
src/api/types/nes.types.ts Removes custom type definitions replaced by shared package
src/api/types/hd-cli.types.ts Removes custom CLI types replaced by shared package
src/api/queries/nes/sbom.ts Updates GraphQL mutation to use new EOL report creation endpoint
src/api/nes/nes.client.ts Simplifies client by removing batching logic and using shared types
src/service/nes/nes.svc.ts Updates service to use new API contract and shared types
src/commands/scan/eol.ts Updates command logic to work with new EolReport structure
src/ui/shared.ui.ts Updates imports to use shared ComponentStatus type
test/api/nes.client.test.ts Removes tests for deprecated batching functionality
test/utils/mocks/scan-result-component.mock.ts Removes mock utilities for deprecated types
e2e/scan/eol.test.ts Updates e2e tests to work with new API response structure
.github/workflows/ci.yml Updates environment variable for new GraphQL host
Comments suppressed due to low confidence (1)

package.json:41

  • The dependency is specified using a GitHub URL with tag v0.1.2. This approach may cause issues with package resolution and version management. Consider publishing this package to npm and using a standard version number instead.
    "@herodevs/eol-shared": "github:herodevs/eol-shared#v0.1.2",

Comment thread src/api/queries/nes/sbom.ts
Comment thread src/api/queries/nes/sbom.ts Outdated
Copy link
Copy Markdown
Contributor

@KLongmuirHD KLongmuirHD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment

@rlmestre rlmestre dismissed KLongmuirHD’s stale review August 1, 2025 13:47

comments addressed

@rlmestre rlmestre merged commit d92bb37 into main Aug 1, 2025
12 checks passed
@rlmestre rlmestre deleted the feat/new-eol-api-contract branch August 1, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants