feat: update logic to adhere to new EOL-API contract#290
Merged
Conversation
e3c1164 to
01feb58
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the application to adhere to a new EOL-API contract, migrating from the old NES-specific API to a new shared EOL API contract using the @herodevs/eol-shared package.
- Replaces custom type definitions with shared types from
@herodevs/eol-shared - Updates GraphQL mutations and API client methods to use the new EOL report creation endpoint
- Removes batching logic and simplifies scan submission workflow
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Adds @herodevs/eol-shared dependency for shared types |
| src/api/types/nes.types.ts | Removes custom type definitions replaced by shared package |
| src/api/types/hd-cli.types.ts | Removes custom CLI types replaced by shared package |
| src/api/queries/nes/sbom.ts | Updates GraphQL mutation to use new EOL report creation endpoint |
| src/api/nes/nes.client.ts | Simplifies client by removing batching logic and using shared types |
| src/service/nes/nes.svc.ts | Updates service to use new API contract and shared types |
| src/commands/scan/eol.ts | Updates command logic to work with new EolReport structure |
| src/ui/shared.ui.ts | Updates imports to use shared ComponentStatus type |
| test/api/nes.client.test.ts | Removes tests for deprecated batching functionality |
| test/utils/mocks/scan-result-component.mock.ts | Removes mock utilities for deprecated types |
| e2e/scan/eol.test.ts | Updates e2e tests to work with new API response structure |
| .github/workflows/ci.yml | Updates environment variable for new GraphQL host |
Comments suppressed due to low confidence (1)
package.json:41
- The dependency is specified using a GitHub URL with tag v0.1.2. This approach may cause issues with package resolution and version management. Consider publishing this package to npm and using a standard version number instead.
"@herodevs/eol-shared": "github:herodevs/eol-shared#v0.1.2",
sunshastry
approved these changes
Jul 31, 2025
KLongmuirHD
reviewed
Jul 31, 2025
KLongmuirHD
approved these changes
Jul 31, 2025
KLongmuirHD
reviewed
Jul 31, 2025
jeremymwells
approved these changes
Aug 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes neverendingsupport/data-and-integrations#128
Closes neverendingsupport/data-and-integrations#206
Closes neverendingsupport/data-and-integrations#212