feat: add HeroDevs attribution to SBOM generation#289
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds HeroDevs attribution to generated SBOM files by including HeroDevs as the author and adding the HeroDevs CLI as a tool in the metadata. The PR also improves logging consistency by only showing the "SBOM saved" message when files are actually saved to disk.
- Updates SBOM configuration to include HeroDevs attribution in author and tools metadata
- Refactors logging to show save confirmation message in the correct flow
- Adds comprehensive e2e tests to verify SBOM generation and attribution
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/service/eol/cdx.svc.ts | Adds HeroDevs author and CLI tool attribution to SBOM default options |
| src/commands/scan/sbom.ts | Refactors logging to show save message only when files are saved |
| e2e/scan/sbom.test.ts | Adds comprehensive e2e tests for SBOM generation and attribution verification |
| e2e/fixtures/npm/simple/sbom.json | Updates test fixture with new HeroDevs attribution and additional dependencies |
KLongmuirHD
reviewed
Jul 23, 2025
KLongmuirHD
approved these changes
Jul 23, 2025
sunshastry
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds HeroDevs
authorandtoolsto generated SBOM.Closes neverendingsupport/data-and-integrations/issues/208