feat: publish eol-scan image#282
Merged
Merged
Conversation
rlmestre
force-pushed
the
feat/scan-image
branch
9 times, most recently
from
f51d19f to
40163b8
Compare
rlmestre
force-pushed
the
feat/scan-image
branch
from
40163b8 to
5ab777a
Compare
KLongmuirHD
requested changes
Jul 11, 2025
rlmestre
force-pushed
the
feat/scan-image
branch
from
befa961 to
33aa795
Compare
KLongmuirHD
requested changes
Jul 14, 2025
KLongmuirHD
approved these changes
Jul 14, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for building and publishing a new eol-scan Docker image, updates CI workflows, and extends documentation with CI/CD usage examples.
- Introduces
ci/image.Dockerfileto package the HeroDevs CLI for EOL scanning. - Updates GitHub Actions workflows to build and push the Docker image.
- Expands
README.mdwith Docker- and npx-based CI/CD setup instructions. - Refactors the CI matrix in
.github/workflows/ci.ymlfor conciseness.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ci/image.Dockerfile | New Dockerfile for the eol-scan image |
| README.md | Added CI/CD usage examples and Docker image instructions |
| .github/workflows/release.yml | Added publish-images job to build and push Docker image |
| .github/workflows/ci.yml | Simplified matrix definition and added max-parallel |
Comments suppressed due to low confidence (2)
.github/workflows/release.yml:53
- [nitpick] Pinning
actions/checkoutto a specific commit SHA can hinder future updates and maintenance. It’s generally better to reference a stable release tag likeactions/checkout@v4.
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
README.md:330
- The CLI invocation is missing a space between
npxand the package name. It should benpx @herodevs/cli@betato run correctly.
- npx@herodevs/cli@beta
dannysauer
reviewed
Jul 16, 2025
marco-ippolito
approved these changes
Jul 16, 2025
dannysauer
reviewed
Jul 16, 2025
dannysauer
approved these changes
Jul 16, 2025
Contributor
dannysauer
left a comment
dannysauer
left a comment
There was a problem hiding this comment.
Looks fine to me, but maybe double-check that chunk of README. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes neverendingsupport/data-and-integrations#137
Closes neverendingsupport/data-and-integrations#138
Closes neverendingsupport/data-and-integrations#139