feat: add scan progress descriptions and loaders#277
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR replaces oclif’s ux.action with ora spinners to provide clearer progress feedback during SBOM generation/loading and EOL scanning, and adds ora as a dependency.
- Introduces
oraspinners around SBOM creation/loading and EOL package scanning. - Removes previous
ux.action.start/stopcalls. - Updates
package.jsonto include theoradependency.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/commands/scan/sbom.ts | Replaced ux.action calls with ora spinner logic |
| src/commands/scan/eol.ts | Added ora spinners for purls file loading and EOL scan |
| package.json | Added "ora": "^8.2.0" dependency |
Comments suppressed due to low confidence (1)
src/commands/scan/sbom.ts:80
- [nitpick] You're mixing use of
flags.fileand the destructuredfilevariable. For consistency, reference the localfilevariable here (e.g.,file ? 'Loading SBOM file' : 'Generating SBOM').
spinner.start(flags.file ? 'Loading SBOM file' : 'Generating SBOM');
edezekiel
approved these changes
Jul 3, 2025
KLongmuirHD
approved these changes
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/neverendingsupport/data-and-integrations/issues/118
Screen.Recording.2025-07-02.at.9.53.04.AM.mov