Skip to content

feat: add scan progress descriptions and loaders#277

Merged
rlmestre merged 2 commits into
mainfrom
feat/progress-descriptions
Jul 3, 2025
Merged

feat: add scan progress descriptions and loaders#277
rlmestre merged 2 commits into
mainfrom
feat/progress-descriptions

Conversation

@rlmestre
Copy link
Copy Markdown
Contributor

@rlmestre rlmestre commented Jul 2, 2025

Closes https://github.com/neverendingsupport/data-and-integrations/issues/118

Screen.Recording.2025-07-02.at.9.53.04.AM.mov

@rlmestre rlmestre requested a review from a team as a code owner July 2, 2025 15:03
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces oclif’s ux.action with ora spinners to provide clearer progress feedback during SBOM generation/loading and EOL scanning, and adds ora as a dependency.

  • Introduces ora spinners around SBOM creation/loading and EOL package scanning.
  • Removes previous ux.action.start/stop calls.
  • Updates package.json to include the ora dependency.

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/commands/scan/sbom.ts Replaced ux.action calls with ora spinner logic
src/commands/scan/eol.ts Added ora spinners for purls file loading and EOL scan
package.json Added "ora": "^8.2.0" dependency
Comments suppressed due to low confidence (1)

src/commands/scan/sbom.ts:80

  • [nitpick] You're mixing use of flags.file and the destructured file variable. For consistency, reference the local file variable here (e.g., file ? 'Loading SBOM file' : 'Generating SBOM').
      spinner.start(flags.file ? 'Loading SBOM file' : 'Generating SBOM');

Comment thread src/commands/scan/eol.ts Outdated
Comment thread src/commands/scan/eol.ts Outdated
@rlmestre rlmestre merged commit 8ab1074 into main Jul 3, 2025
12 checks passed
@rlmestre rlmestre deleted the feat/progress-descriptions branch July 3, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants