Skip to content

chore: remap SUPPORTED status locally for backwards compatibility#272

Merged
rlmestre merged 1 commit into
mainfrom
chore/rename-supported-locally
Jun 25, 2025
Merged

chore: remap SUPPORTED status locally for backwards compatibility#272
rlmestre merged 1 commit into
mainfrom
chore/rename-supported-locally

Conversation

@rlmestre
Copy link
Copy Markdown
Contributor

The API change to rename SUPPORTED to EOL_UPCOMING was reverted for backwards compatibility. Since we do want to use that name for display purposes, we remap it here instead of reverting the related commit, ensuring the expected value is displayed in the JSON report as well.

@rlmestre rlmestre requested a review from a team as a code owner June 24, 2025 13:48
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

A patch to maintain backwards compatibility by remapping the legacy SUPPORTED status to EOL_UPCOMING in the JSON report instead of reverting the API rename.

  • Extends the ComponentStatus union locally to include 'SUPPORTED'.
  • Adds logic in buildScanResult to convert 'SUPPORTED' to 'EOL_UPCOMING'.
Comments suppressed due to low confidence (2)

src/service/nes/nes.svc.ts:16

  • [nitpick] The local variable status shadows the status property on c.info. Consider renaming it to mappedStatus or similar to improve readability.
    const status = c.info.status as ComponentStatus | 'SUPPORTED';

src/service/nes/nes.svc.ts:21

  • Add a unit test to verify that when c.info.status is 'SUPPORTED', the output status is correctly remapped to 'EOL_UPCOMING'.
        status: status === 'SUPPORTED' ? 'EOL_UPCOMING' : status,

Comment thread src/service/nes/nes.svc.ts
Comment thread src/service/nes/nes.svc.ts
@rlmestre rlmestre merged commit afedac0 into main Jun 25, 2025
23 of 24 checks passed
@rlmestre rlmestre deleted the chore/rename-supported-locally branch June 25, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants