chore: rename SUPPORTED to EOL_UPCOMING#263
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Renames the legacy SUPPORTED status to EOL_UPCOMING across UI, command logic, type definitions, and documentation.
- Replace
SUPPORTEDkeys withEOL_UPCOMINGin status color mappings and indicators. - Update scan command output and count logic to use
EOL_UPCOMINGinstead ofSUPPORTED. - Adjust valid statuses in API types and clean up README usage flags.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/ui/shared.ui.ts | Renamed SUPPORTED to EOL_UPCOMING in STATUS_COLORS and INDICATORS. |
| src/commands/scan/eol.ts | Replaced SUPPORTED references with EOL_UPCOMING in destructuring, conditionals, logging, and grouping. |
| src/api/types/nes.types.ts | Updated VALID_STATUSES constant to include EOL_UPCOMING. |
| README.md | Removed references to the --all flag (formerly showing SUPPORTED) and updated usage examples. |
Comments suppressed due to low confidence (2)
README.md:148
- The USAGE line includes
--jsonand-sbut the FLAGS section no longer documents those options. Please add descriptions for--jsonand-sor remove them from the usage line to keep the documentation in sync.
$ hd scan eol [--json] [-f <value>] [-p <value>] [-d <value>] [-s]
src/commands/scan/eol.ts:175
- Add or update tests to verify that
EOL_UPCOMINGis correctly counted incountComponentsByStatusand displayed indisplayResults.
EOL_UPCOMING: 0,
KLongmuirHD
approved these changes
Jun 20, 2025
edezekiel
approved these changes
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial change for https://github.com/neverendingsupport/data-and-integrations/issues/95. Does not close it yet because we need to make the same change in the report card too.