fix: ensure e2e tests don't run against prod#250
Merged
Conversation
Previously, the e2e tests were being run against prod. This was not the intention. Process env variables were set in multiple places: - bin/run.js - bin/dev.js - eol.test.ts - src/config/constants.ts This allowed for the `config` and the `process.env` vars to get out of sync, which caused unexpected results for the value of those vars during e2e tests. This commit consolidates to the `config` as the source of truth for env vars. I've deleted the attempts to set env vars everywhere else. For convenience, I've added a `.envrc.example` file showing how to set development vars. You can use `direnv allow` to load vars in a .envrc file.[1] [1]https://github.com/direnv/direnv/tree/master
rlmestre
approved these changes
Jun 6, 2025
jeremymwells
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the e2e tests were being run against prod. This was not the intention. Process env variables were set in multiple places:
This allowed for the
configand theprocess.envvars to get out of sync, which caused unexpected results for the value of those vars during e2e tests.This commit consolidates to the
configas the source of truth for env vars. I've deleted the attempts to set env vars everywhere else.For convenience, I've added a
.envrc.examplefile showing how to set development vars. You can usedirenv allowto load vars in a .envrc file.[1]Skipping
extra-largefixture e2e testRecent changes to the api is causing the e2e test to be flaky. The api team is aware and working towards a resolution. Until then, I'm skipping the e2e spec involving that fixture.
[1]https://github.com/direnv/direnv/tree/master