fix: ensure purls are deduped and encoded#242
Merged
Conversation
KLongmuirHD
approved these changes
May 27, 2025
rlmestre
approved these changes
May 29, 2025
marco-ippolito
approved these changes
May 29, 2025
rlmestre
reviewed
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cdxgen can yield unencoded and duplicative purls. For example,
pkg:npm/@angular/core@14.3.0andpkg:npm/%40angular/core@14.3.0. This PR ensures that purls are encoded and deduped before being sent to the api. Whether the api should unencode them on the way 'out the door' so to speak is a separate issue. They should be saved in the encoded format.