Skip to content

feat: enable vuln count feature #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marco-ippolito merged 2 commits into from
Apr 18, 2025
Merged

feat: enable vuln count feature #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c827eb
feat: enable vuln count feature
edezekiel Apr 17, 2025
eb1e9d1
chore: fix linting error
edezekiel Apr 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions bin/dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,7 @@ process.env.GRAPHQL_HOST = 'http://localhost:3000';
// Dev
// process.env.GRAPHQL_HOST = 'https://api.dev.nes.herodevs.com';

// Prod
// process.env.GRAPHQL_HOST = 'https://api.nes.herodevs.com';

await execute({ development: true, dir: import.meta.url });
6 changes: 1 addition & 5 deletions e2e/scan/eol.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,11 +116,7 @@ describe('scan:eol e2e', () => {

// Match table header
match(stdout, /┌.*┬.*┬.*┬.*┬.*┐/, 'Should show table top border');
match(
stdout,
/│ NAME\s*│ VERSION\s*│ EOL\s*│ DAYS EOL\s*│ TYPE\s*│/, // TODO: add vulns to monorepo api
'Should show table headers',
);
match(stdout, /│ NAME\s*│ VERSION\s*│ EOL\s*│ DAYS EOL\s*│ TYPE\s*│ # OF VULNS*|/, 'Should show table headers');
match(stdout, /├.*┼.*┼.*┼.*┼.*┤/, 'Should show table header separator');

// Match table content
Expand Down
3 changes: 1 addition & 2 deletions src/api/queries/nes/sbom.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@ export const M_SCAN = {
eolAt
daysEol
status
# TODO: uncomment vulnCount once backend changes are deployed
# vulnCount
vulnCount
}
}
diagnostics
Expand Down
6 changes: 0 additions & 6 deletions src/service/nes/nes.svc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,6 @@ import { debugLogger } from '../log.svc.ts';
export const buildScanResult = (scan: InsightsEolScanResult): ScanResult => {
const components = new Map<string, InsightsEolScanComponent>();
for (const c of scan.components) {
const { status } = c.info;
// TODO: remove this once backend changes are deployed
// @ts-expect-error
if (status === 'LTS') {
c.info.status = 'SUPPORTED';
}
components.set(c.purl, c);
}

Expand Down