Add TaskSolver as abstraction layer over ModelChecker#1022
Open
ThomasHaas wants to merge 13 commits intodevelopmentfrom
Open
Add TaskSolver as abstraction layer over ModelChecker#1022ThomasHaas wants to merge 13 commits intodevelopmentfrom
ThomasHaas wants to merge 13 commits intodevelopmentfrom
Conversation
Moved most of Dartagnan.java's output generation code to TaskResultAnalyzer
Minor refactor
Improve AbstractCompilationTest compilability check
Minor cleanup Fix in SVCOMPRunner.java which referenced old method
xeren
reviewed
Apr 10, 2026
| // Verification ended, nothing to be done. | ||
| } | ||
| }); | ||
| } |
Collaborator
There was a problem hiding this comment.
You should capture timeout and modelChecker in the lambda's closure, or join timeoutThread in run(). The accesses here are potentially racy, e.g. with modelChecker = null in close().
Collaborator
Author
There was a problem hiding this comment.
I guess we could add a join() after the interrupt(). The join should then return more or less instantly.
The case you have in mind seems to be an extreme edge-case where the model checker returns right before the timeout, the interrupt gets send but doesn't arrive quickly enough (though the target thread is sleeping and therefore listens to interrupts) before the task solver gets closed and the timeout thread reaches its timeout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new abstraction layer before the ModelChecker. For now, this layer does not do much apart from choosing the appropriate ModelChecker and managing timeouts.
However, the intend is to make this layer more powerful in the future and enable more interesting solving approaches such as:
TODO: Update reflection metadata for native build.EDIT: I also added a
TaskResultAnalyzerclass that is now responsible for generating theResultSummaryand witness files. Basically, I moved all output generation fromDartagnan.javatoTaskResultAnalyzerEDIT 2: I took the freedom to clean up
Dartagnan.java. I think it is a lot easier to follow the logic of Dartagnan now.