Add configurable skip patterns for cargo build script execroot symlinking#7
Open
walter-zeromatter wants to merge 25 commits intohermeticbuild:mainfrom
Open
Add configurable skip patterns for cargo build script execroot symlinking#7walter-zeromatter wants to merge 25 commits intohermeticbuild:mainfrom
walter-zeromatter wants to merge 25 commits intohermeticbuild:mainfrom
Conversation
…elbuild#3829)" This reverts commit f198dde.
…() (bazelbuild#3816)" This reverts commit 9586468.
…#3) * 0 * Add rust analyzer test coverage
Replace the --rustc-quit-on-rmeta / .rmeta approach with Buck2-style hollow rlibs: the RustcMetadata action runs rustc to completion with -Zno-codegen, emitting a .rlib archive (named -hollow.rlib) that contains only metadata and optimized MIR. Key fixes: - Main Rustc action uses full rlib --extern deps so the SVH embedded in the full rlib matches what downstream binaries expect (avoiding E0460 with non-deterministic proc macros). - RUSTC_BOOTSTRAP=1 is set on both actions: it changes the crate hash, so inconsistent use would cause SVH mismatch even for deterministic crates. - -Ldependency= points to the _hollow/ subdirectory so the full rlib and hollow rlib never appear in the same search path (avoids E0463). - transitive_metadata_outputs are always included in the sandbox so rustc can resolve transitive -Ldependency= references. Adds an SVH mismatch test that demonstrates the problem with non-deterministic proc macros (uses a HashMap-based derive macro whose output varies by OS-seeded random seed).
walter-zeromatter
force-pushed
the
pr/cargo-symlink-skip
branch
from
d6bbfce to
d61097b
Compare
…king Adds symlink_exec_root_skip_patterns setting to cargo/settings, allowing users to control which execroot entries are skipped during CARGO_MANIFEST_DIR symlinking. Defaults skip worker temp dirs and VCS directories. Also improves Windows symlink handling: - Correctly handle file symlinks, directory symlinks, and junctions - Tolerate missing runfile entries - Downgrade symlink removal failures to warnings on Windows
walter-zeromatter
force-pushed
the
pr/cargo-symlink-skip
branch
from
d61097b to
a1ec6a8
Compare
…king Adds symlink_exec_root_skip_patterns setting to cargo/settings, allowing users to control which execroot entries are skipped during CARGO_MANIFEST_DIR symlinking. Defaults skip worker temp dirs and VCS directories. Also improves Windows symlink handling: - Correctly handle file symlinks, directory symlinks, and junctions - Tolerate missing runfile entries - Downgrade symlink removal failures to warnings on Windows
dzbarsky
force-pushed
the
main
branch
2 times, most recently
from
d97ab75 to
e1ed0e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
symlink_exec_root_skip_patternssetting for controlling which execroot entries are skipped duringCARGO_MANIFEST_DIRsymlinking