rust: add incremental builds and persistent worker pipelining#11
Open
walter-zeromatter wants to merge 1 commit intohermeticbuild:mainfrom
Open
rust: add incremental builds and persistent worker pipelining#11walter-zeromatter wants to merge 1 commit intohermeticbuild:mainfrom
walter-zeromatter wants to merge 1 commit intohermeticbuild:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
process_wrapperthat enables Cargo-style pipelining — downstream crates can start compiling as soon as.rmetametadata is emitted, without waiting for full codegen. This significantly reduces critical path build times. See DESIGN.md for details on how this works.Key changes
rust/private/rustc.bzl: Wires up worker pipelining flags, metadata actions, and incremental build supportrust/private/incremental.bzl: New file for incremental compilation logicrust/settings/settings.bzl: New settings (experimental_worker_pipelining,experimental_incremental)util/process_wrapper/worker*.rs: Full multiplex worker implementation with pipelining, sandboxing, and cancellation supporttest/unit/pipelined_compilation/: New tests for worker pipelining and strace-based sandbox compliance verificationPerformance
On a 5-crate benchmark (Bazel 8.4.2, no multiplex sandboxing):
Test plan
pipelined_compilationtests passprocess_wrappertests pass