Introduce ErrorCode::NoContent#1665
Merged
rustam-gamidov-here merged 1 commit intomasterfrom Feb 26, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1665 +/- ##
=======================================
Coverage 80.33% 80.33%
=======================================
Files 350 350
Lines 14052 14084 +32
Branches 1517 1517
=======================================
+ Hits 11288 11314 +26
- Misses 2147 2151 +4
- Partials 617 619 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrey-kashcheev
previously approved these changes
Feb 23, 2026
rustam-gamidov-here
force-pushed
the
rga/heresup-50889-introduce-no-content
branch
from
31defea to
e6e216c
Compare
rustam-gamidov-here
requested review from
andrey-kashcheev,
asopov-here,
khomenkd and
mykolamalik
andrey-kashcheev
previously approved these changes
Feb 24, 2026
Allows to distinguish 404 network error and fact that there's no data for the requested resource. This allows to cache NoContent responses and decrease number of such requests Relates-To: HERESUP-50889 Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
rustam-gamidov-here
force-pushed
the
rga/heresup-50889-introduce-no-content
branch
from
e6e216c to
92b4416
Compare
andrey-kashcheev
approved these changes
Feb 25, 2026
mykolamalik
approved these changes
Feb 25, 2026
rustam-gamidov-here
deleted the
rga/heresup-50889-introduce-no-content
branch
asopov-here
pushed a commit
that referenced
this pull request
Feb 27, 2026
Allows to distinguish 404 network error and fact that there's no data for the requested resource. This allows to cache NoContent responses and decrease number of such requests Relates-To: HERESUP-50889 Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows to distinguish 404 network error and fact that there's no data for the requested resource. This allows to cache NoContent responses and decrease number of such requests
Relates-To: HERESUP-50889