Add rotation support for Quad and Sprite#133
Open
danheuck wants to merge 6 commits into
Open
Conversation
effect, sprite and quad positions are now anchored at the center of the sprite/quad. Updated all ui widgets and examples to work with the new anchor point. Updated the image.rs example to include a panel since I needed to make sure I hadn't changed its behavior.
rotation fields for sprites and quads.
progress bar for top left corner anchoring
and reverted change to test/graphics.rs
Author
|
Just added a few more commits that move the anchor point back to the top left corner and revert most of the changes I made to the UI renderers as a consequence of the anchor point moving. |
|
I would like to see this merged aswell. Most games use this feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for rotating individual Quads and Sprites as mentioned in #1. As a side effect, this ended up moving the anchor point for positions to the center of the Sprite/Quad since the Sprites needed to be centered on the origin before they could be rotated. In my opinion, this behavior is often preferable anyway, but I realize it's subjective. I can try to figure out a way to apply the rotation without moving changing the way sprite positioning works if desired, but I'm far from an expert on transformation matrices.
#1 mentioned concerns that adding rotation support would negatively impact performance. I did not add any benchmarks, but anecdotally testing with the particles example did not show any significant difference with or without the change.