Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive deinitialization support to TinyUSB, enabling dynamic switching between USB device and host modes at runtime. The changes introduce new pre-init and post-deinit callback hooks, implement deinit functions across multiple USB controller drivers, and include a new example demonstrating the dual-role switching capability.
Key Changes:
- Added
tusb_pre_init_cb()andtusb_post_deinit_cb()callback hooks with weak default implementations for MCU-specific initialization/cleanup - Implemented deinit support across multiple USB drivers: dwc2 (DCD/HCD), EHCI, and chipidea ci_hs (DCD/HCD)
- Created a new
dynamic_switchexample demonstrating runtime switching between device and host modes via button press
Reviewed changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tusb.h | Declares new pre-init and post-deinit callback hooks |
| src/tusb.c | Provides weak default implementations for the new callback hooks |
| src/host/usbh.c | Integrates pre-init/post-deinit callbacks into host stack init/deinit flow, changes to TU_ASSERT |
| src/device/usbd.c | Integrates pre-init/post-deinit callbacks into device stack init/deinit flow, changes to TU_ASSERT |
| src/portable/synopsys/dwc2/dwc2_common.h | Declares dwc2_core_deinit function |
| src/portable/synopsys/dwc2/dwc2_common.c | Implements core deinit with soft disconnect and reset |
| src/portable/synopsys/dwc2/hcd_dwc2.c | Adds HCD deinit, removes CONIDSTSCHNG interrupt handling, fixes DATATOGGLE_ERR handling |
| src/portable/synopsys/dwc2/dcd_dwc2.c | Adds DCD deinit implementation |
| src/portable/ehci/ehci_api.h | Declares ehci_deinit function |
| src/portable/ehci/ehci.c | Implements EHCI deinit with interrupt/schedule disable |
| src/portable/chipidea/ci_hs/hcd_ci_hs.c | Adds HCD deinit, fixes comment from "device" to "host", fixes full-speed logic |
| src/portable/chipidea/ci_hs/dcd_ci_hs.c | Implements DCD deinit with interrupt disable and endpoint flushing |
| hw/bsp/stm32u5/family.c | Implements tusb_pre_init_cb for role-specific VBUS/OTG configuration, fixes interrupt handler naming |
| hw/bsp/stm32h7rs/family.c | Implements tusb_pre_init_cb with rhport-aware VBUS/OTG configuration |
| hw/bsp/stm32h7rs/boards/stm32h7s3nucleo/board.h | Fixes button active_state from 1 to 0 (active low) |
| hw/bsp/lpc43/family.c | Adds GPIO configuration for VIF_OUT, conditionally includes EA4357 board-specific code |
| examples/dual/dynamic_switch/* | New example demonstrating dynamic device/host mode switching with CDC echo and host enumeration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Size Difference ReportBecause TinyUSB code size varies by port and configuration, the metrics below represent the averaged totals across all example builds. Note: If there is no change, only one value is shown. Changes >1% in size
Changes <1% in size
No changes
|
HiFiPhile
force-pushed
the
ci_deinit
branch
3 times, most recently
from
1893a2a to
8ae01ea
Compare
Owner
|
@HiFiPhile we may need to re-base this as well |
Signed-off-by: Zixun LI <admin@hifiphile.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Zixun LI <admin@hifiphile.com>
Collaborator
Author
|
@hathach Rebase done |
Owner
|
@claude review this |
hathach
approved these changes
Mar 6, 2026
Owner
hathach
left a comment
hathach
left a comment
There was a problem hiding this comment.
perfect, this look good. THank you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Tested on LPC4322 with new dynamic_switch example.
Rebase after #3378