Conversation
b9671b4 to
380c8e8
Compare
380c8e8 to
4fc19b6
Compare
Collaborator
|
@mur-me - check the failed rpc tests, fix should be simple, see the golang tests from this PR |
Frozen
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes error field truly optional in tracer logger.
StructLogRes.Errorwas a string. Even when there was no error, JSON had "error": "". After changes, It’s a *string withomitempty, and we only set it when there is a real error message. Many tracers/INDEXERS/specs expect the field to be absent when no error occurs, not present with "". This fixes schema/decoder issues and false “error” detections.Current memory was chunked into 32‑byte slices and encoded with
fmt.Sprintf("%x", slice). A partial word (e.g. 2 bytes) gave "0xaabb" instead of a 32‑byte (64‑hex‑char) word. After changes each memory chunk is:hexutil.Bytes(word).String()→ 0x + 64 hex chars.Tools that assume 32‑byte, zero‑padded, 0x‑prefixed words (as in Geth) no longer break or misinterpret short words at the end of memory.
Also, the PR helps the storage and return data hex encoding is now consistent. In current code:
Storage keys/values were
fmt.Sprintf("%x", hash)→ no 0x prefix, inconsistent with most Ethereum JSON APIs.ExecutionResult.ReturnValuewas a plain hex string and manually blanked out on failure.But the PR changes it to:
hash.Hex()for both key and value → consistent 0x‑prefixed hex.hexutil.Bytes, and we zero the underlying bytes on hard failure.So, now debuggers and explorers that expect standard 0x‑prefixed hex (like the Execution APIs / Geth) can work with your traces without custom handling.
The PR fixes debug_traceTransaction style output’s JSON shape and hex formats now match what existing Ethereum tooling already knows how to parse.
Note: the same changes on Ethereum can be found on PR#34093