Open
Conversation
Owner
|
Thanks, any reason why you'd need a non-static lifetime in the new_from_slice? e.g., would this be simpler:
|
Author
|
I'm not exactly sure. If you're writing a kernel, then you'll most likely load it with Not requiring it might be helpful for tests or VMs or something like that, but I don't know. I would be fine with the static lifetime just in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was happy to be able to use this crate for creating a GDT like this:
This worked in a debug build, but failed in a release build because the array containing the descriptors did not live long enough. I spent some time finding this issue, so I figured it might be nice to express these constraints via lifetimes.
I'm not sure about disallowing access to the limit and base pointer but they probably shouldn't be writable.