Open
Conversation
Contributor
Author
|
@gyscos, can you review this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
persistentflag to type level. Now compiler knows it value at compile time and optimize it away. It almost have no impact on performance, but it helps to split implementation offlush_to_backend()on 2 cases and may helps to experiment and optimize in the future.clone_from_slice()with manual copyactualcell tofrozen. First of all, I want to noteCellis notCopy, and can't be copied as 1 slice of memory, therefore I supposeclone_from_slice()unfolded by compiler just in loop of clones fromactualcell tofrozen. Мoving thisclone()to the existing loop like in PR changes usually we skip many call ofclone(), because of in common case changing only part of screen, and amortize cloning by parallel execution on cpu instruction level.By my tests of performance this changes give about 20-30% speed up
For tests I measure time of invocation
PrintBuffer::flush()on different examples:time_lorem_(war_and_peace)_after.txt
time_lorem_(war_and_peace)_before.txt
time_lorem_after.txt
time_lorem_before.txt
time_progress_after.txt
time_progress_before.txt
time_progress_mod_after.txt
time_progress_mod_before.txt
UPDATE:
Added compare styles by value. It reduces about 3 additional microseconds (6%)