Conversation
- package.json: packageManager=pnpm@10.33.4, engines.node>=24, version 0.10.0 -> 0.10.1 - .npmrc: point @gynzy at GitHub Packages - .nvmrc: 24 - drop .yarnrc
Generated via jgen against lib-jsonnet PR-257. Replaces handwritten publish-pr.yml/publish-tag.yml that targeted npm.gynzy.net. - repositories=['github'] (publish only to GitHub Packages) - isPublicFork=true (repo visibility is PUBLIC) - buildSteps=[] (legacy ci/publish.sh never built before publishing) - testJob runs 'pnpm run lint' (browser-dependent ember tests require infra not present in node:24 container; flagged in PR)
pnpm pack before: 49 files / 49,727 B (shipped .github/jsonnet helpers, .github.jsonnet, .github/workflows YAML, .claude/, .nvmrc, ci/*.sh, CHANGELOG, CONTRIBUTING). pnpm pack after: 14 files / 5,771 B (-88% size, -71% files).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Migrate this package to pnpm@10.33.4, Node 24, and GitHub-Packages-only publishing on top of
util.workflowJavascriptPackage()from lib-jsonnet. Also performs a publish-hygiene pass adding afilesallowlist.lib-jsonnet bootstrap
This repo was bootstrapped to lib-jsonnet as part of this PR (no
.github/jsonnet/existed before). Helpers were extracted fromhttps://files.gynzy.net/lib-jsonnet/v1/jsonnet-pr-257.tar.gz.Depends on lib-jsonnet#257 (adds
packageManager='pnpm'toworkflowJavascriptPackage). Follow-up once adopted-ember-addons#257 merges to prod: re-runsh .github/jsonnet/pull-upstream-and-rebuild.shwithoutPR_NUMBERto repin helpers to prod and regenerate.Discovery
mainPUBLIC→isPublicFork=true0.10.0→0.10.1npm-run-all lint:* test:*(lint:js, test:ember, test:ember-compatibility)ember build --environment=productionnpm-run-all --parallel lint:*Workflow generation
repositories=['github']— GitHub Packages only (hard requirement: no npm.gynzy.net, nosetGynzyNpmToken). Verified: generated YAML contains zero references to either.isPublicFork=true(visibility PUBLIC).buildSteps=[]— the legacyci/publish.shpublishedyarn publishdirectly without a build step; preserving original behavior. Also:ember builddoes not run on Node 24 with the pinned Ember 3.27 toolchain.testJobrunspnpm run lint(eslint) only.test:emberandtest:ember-compatibilityneed a browser environment that thenode:24container does not provide; Travis previously usedchrome: stableaddon. Flagged below.Legacy
.github/workflows/publish-pr.ymlandpublish-tag.ymlwere deleted (superseded by helper-generatedpr.ymlandpublish-prod.yml).Publish hygiene
Baseline
pnpm pack(before allowlist): 49 files / 49,727 B. Junk shipped:.github.jsonnet, all of.github/jsonnet/*,.github/workflows/*.yml,.claude/,.nvmrc,ci/npm.sh,ci/publish.sh,CHANGELOG.md,CONTRIBUTING.md.CI bloat risk (generated workflows):
pnpm config set store-dir .pnpm-store && pnpm install --frozen-lockfileruns beforepnpm publish, which without an allowlist would balloon the published tarball with the pnpm store. The allowlist neutralises this.Applied:
files:["addon", "app", "config/environment.js", "index.js"].npmignoredeleted (allowlist makes it redundant; the only residual noise inside allowlisted paths is two 0-byte.gitkeepfiles — harmless).After: 14 files / 5,771 B (–88% size, –71% files).
Local verification
pnpm install— clean.pnpm run lint:js— passes.pnpm run build— fails on Node 24 (pre-existing Ember 3.27 / Node-24 incompatibility); not wired into CI testJob or publish-prod (buildSteps=[]).pnpm run test— not run (browser-dependent ember tests; see Open Questions).Preserved
.travis.ymlleft as-is (not a GH Actions workflow). Travis is the historical home of ember-try matrix tests.ci/npm.sh,ci/publish.shleft as-is (orphaned scripts, no longer referenced by any workflow). Can be removed in a follow-up.Open Questions
publish-tag.ymlfired onpush: tags: '*'. The new helper publishes onpushtomain. Confirm whether tag-based releases are still desired; if so, additional jsonnet is needed.test:emberandtest:ember-compatibilityneed a browser. They previously ran on Travis with Chrome installed. Wiring them in GH Actions requires a service container or runner-installed browser — out of scope for this migration. They are NOT run in CI by this PR.ci/npm.sh/ci/publish.shorphan removal: not part of this PR per minimum-change rule; suggest deleting in a follow-up.