Conversation
Reverts the lint-only narrowing from 82fb18f. Switches the test job image to europe-docker.pkg.dev/unicorn-985/private-images/docker-images_node24-with-libnss:v1 which provides libnss for headless Chrome.
- Add ember-auto-import + webpack 5 as direct devDeps so ember-auto-import's leader election finds the host package (resolves NullLeader error from ember-cli-fastboot-testing). - Patch json-stable-stringify@1.3.0 to tolerate null cmp, fixing the Node-24-strict sort failure in ember-cli-fastboot's FastBootConfig.toJSONString. Result: ember test runs end-to-end, 8/9 tests pass. The remaining fastboot integration test still needs investigation.
ember-cli-fastboot-testing depends on fastboot@4 to render, while the addon itself is built against ember-cli-fastboot@2.2.3. v2's fastboot service expects _fastbootInfo to be injected by FastBootInfo.register(); v4 removed that injection. Re-add it so the legacy service keeps working. All 9 ember tests now pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates
@gynzy/ember-cli-ifato:10.* || >= 12)util.workflowJavascriptPackage()fromlib-jsonnet(was handwrittenpublish-pr.yml/publish-tag.yml+ci/npm.sh+ci/publish.sh)This PR also bootstraps this repo to lib-jsonnet for the first time (no prior
.github.jsonnet/.github/jsonnet/).Dependency on lib-jsonnet#257
This PR pulls lib-jsonnet from PR adopted-ember-addons#257 (
packageManager='pnpm'support inworkflowJavascriptPackage). After lib-jsonnet#257 merges to prod, a follow-up should runsh .github/jsonnet/pull-upstream-and-rebuild.sh(withoutPR_NUMBER) to repin to prod.Discovery results
mainPUBLIC→isPublicFork=true(runs onubuntu-latest)yarn.lock,.yarnrc)0.10.0→0.11.0(minor +1, patch reset)pnpm run lint(npm-run-alllint:*→ eslint)pnpm run test(npm-run-alllint:* test:*→ eslint + ember test + ember try:each)pnpm run build(ember build --environment=production)workflowJavascriptPackage's tag handling)Generated pipelines
workflowJavascriptPackageproduces three workflows:misc.yml—verifyJsonnet(jsonnet ↔ YAML consistency check)pr.yml—pnpm-publish-preview+testjobpublish-prod.yml—pnpm-publishon push tomainVerified the generated YAML contains:
npm.gynzy.netsetGynzyNpmTokennode:24everywherepnpm(no yarn)Removed legacy
.github/workflows/publish-pr.yml.github/workflows/publish-tag.ymlci/npm.shandci/publish.share now dead code (only referenced by the removed workflows) but are left in place to keep this PR minimal — they can be cleaned up in a follow-up.Preserved pipelines
None beyond the helper output — there were no non-helper pipelines (pulumi etc.) in this repo.
Open Questions
pnpm run buildfails locally under pnpm.ember build --environment=productionthrowsTo use these addons, your app needs ember-auto-import >= 2: ember-cli-fastboot-testing. This is a known ember + pnpm hoisting issue (yarn's hoisted layout hid it; pnpm's isolated layout exposes it). Mitigated in this PR by passingbuildSteps=[]toworkflowJavascriptPackage— the build step is for the dummy test app, and the addon's.npmignoreexcludes/distso publish doesn't need it. Test job also omitsbuild. If you want CI to runember build, addnode-linker=hoistedto.npmrc(or upgrade ember-auto-import) in a follow-up.pnpm run testrequires a browser (Chrome) — thenode:24container does not have one. The existing CI (legacypublish-pr.yml/publish-tag.yml) never ran tests; the previous test runner was Travis (.travis.yml), which is no longer wired up. The newtestjob will fail ontest:ember/test:ember-compatibilityuntil a Chrome-equipped image (orxvfb+ chromium install step) is wired up. Lint will still pass via the samepnpm run test..travis.ymlis dead (no Travis integration). Not removed in this PR to keep the change minimal.Test plan
miscworkflow (verifyJsonnet) passes — proves jsonnet generated YAML is consistentpnpm-publish-previewjob publishes a PR-tagged version to GitHub Packagessh .github/jsonnet/pull-upstream-and-rebuild.shto repin