Skip to content

Simplify hosted content header#15420

Merged
cemms1 merged 8 commits intomainfrom
cemms1/simplify-hosted-header
Mar 24, 2026
Merged

Simplify hosted content header#15420
cemms1 merged 8 commits intomainfrom
cemms1/simplify-hosted-header

Conversation

@cemms1
Copy link
Copy Markdown
Contributor

@cemms1 cemms1 commented Feb 24, 2026

What does this change?

  • Specifies the header element as the semantic HTML element for the header in the Section parent component for the Hosted content page layouts

HostedContentHeader updates:

  • Removes the "About" text
  • Sets the width of the logo + advertisement content label as 132px across all breakpoints
  • Adds an i icon button to the advertisement content label
  • Moves the "hosted by" text to the bottom left of the Guardian Logo and updates the text colour
  • Adjusts the CSS for the header and removes wrapper components in favour of keeping the HTML definition closer together
    • Uses the CSS styles as a way to name/annotate the div layers
  • Removes extra nested div elements from the DOM tree for HostedContentHeader
  • Sets a background colour for the logo container in case the logo is transparent

Note

This does not implement the popover/tooltip component for the information icon hover or onClick action. This will be done in a subsequent PR

Why?

Tweaking the page layouts for the Hosted Content pages to bring them closer to our new, reworked designs for these pages for the migration

Screenshots

Screenshot
Before (frontend) before
Before (DCR) before2
After (DCR) after

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 24, 2026

Comment thread dotcom-rendering/src/components/HostedContentHeader.tsx
Comment thread dotcom-rendering/src/components/HostedContentHeader.tsx
Comment on lines +68 to +69
/** Hard-coded to fit. TODO - address this */
font-size: 13px;
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to talk to design about this. The designs don't work in practice

Comment thread dotcom-rendering/src/components/HostedContentHeader.tsx
Comment thread dotcom-rendering/src/layouts/HostedArticleLayout.tsx
@cemms1 cemms1 force-pushed the cemms1/simplify-hosted-header branch from a4e7d71 to 95ab406 Compare February 24, 2026 16:28
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 24, 2026

@cemms1 cemms1 added the run_chromatic Runs chromatic when label is applied label Feb 24, 2026
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Feb 24, 2026
@cemms1 cemms1 force-pushed the cemms1/simplify-hosted-header branch from 95ab406 to 80b5b54 Compare February 25, 2026 17:51
@cemms1 cemms1 added the run_chromatic Runs chromatic when label is applied label Feb 25, 2026
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Feb 25, 2026
@cemms1 cemms1 force-pushed the cemms1/simplify-hosted-header branch from 80b5b54 to ac36997 Compare March 10, 2026 11:32
@cemms1 cemms1 force-pushed the cemms1/simplify-hosted-header branch from ac36997 to c8ea3cc Compare March 19, 2026 15:15
@cemms1 cemms1 added the run_chromatic Runs chromatic when label is applied label Mar 19, 2026
@cemms1 cemms1 marked this pull request as ready for review March 19, 2026 15:42
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Mar 19, 2026
@cemms1 cemms1 added the run_chromatic Runs chromatic when label is applied label Mar 19, 2026
@cemms1 cemms1 requested a review from a team March 19, 2026 15:45
@cemms1 cemms1 added the feature Departmental tracking: work on a new feature label Mar 19, 2026
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Mar 19, 2026
@cemms1 cemms1 force-pushed the cemms1/simplify-hosted-header branch from 3721ea1 to 0b2fd97 Compare March 24, 2026 10:47
@cemms1 cemms1 added the run_chromatic Runs chromatic when label is applied label Mar 24, 2026
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Mar 24, 2026
@cemms1 cemms1 force-pushed the cemms1/simplify-hosted-header branch from 0b2fd97 to 49c1c66 Compare March 24, 2026 12:33
@cemms1 cemms1 added run_chromatic Runs chromatic when label is applied maintenance Departmental tracking: maintenance work, not a fix or a feature and removed feature Departmental tracking: work on a new feature labels Mar 24, 2026
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Mar 24, 2026
@cemms1 cemms1 merged commit 777a7c1 into main Mar 24, 2026
30 checks passed
@cemms1 cemms1 deleted the cemms1/simplify-hosted-header branch March 24, 2026 14:00
@gu-prout
Copy link
Copy Markdown

gu-prout Bot commented Mar 24, 2026

Seen on PROD (merged by @cemms1 8 minutes and 10 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Commercial 💰 maintenance Departmental tracking: maintenance work, not a fix or a feature Seen-on-PROD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants