Fix nested figure elements in interactive layout atoms#15345
Merged
frederickobrien merged 1 commit intomainfrom Mar 20, 2026
Merged
Fix nested figure elements in interactive layout atoms#15345frederickobrien merged 1 commit intomainfrom
figure elements in interactive layout atoms#15345frederickobrien merged 1 commit intomainfrom
Conversation
|
"This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days" |
frederickobrien
force-pushed
the
remove-figure-inside-figure-for-interactive-atoms
branch
from
0414cdd to
89e83e5
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
frederickobrien
force-pushed
the
remove-figure-inside-figure-for-interactive-atoms
branch
from
89e83e5 to
6dde55c
Compare
RikRootsGuardian
approved these changes
Mar 17, 2026
Contributor
RikRootsGuardian
left a comment
RikRootsGuardian
left a comment
There was a problem hiding this comment.
So happy that <figure><figure></figure></figure> will no longer haunt our nightmares - though, surprisingly, it's entirely legal HTML!
Approved
jonathonherbert
approved these changes
Mar 17, 2026
Contributor
jonathonherbert
left a comment
jonathonherbert
left a comment
There was a problem hiding this comment.
Seems reasonable!
frederickobrien
force-pushed
the
remove-figure-inside-figure-for-interactive-atoms
branch
from
6dde55c to
3647200
Compare
github-actions
Bot
removed
the
run_chromatic
frederickobrien
deleted the
remove-figure-inside-figure-for-interactive-atoms
branch
|
Seen on PROD (merged by @frederickobrien 7 minutes and 52 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses a longstanding semantic structure issue where interactive atoms are being rendered as
<figure>elements within<figure>elements. This tidies that up by removing the inner one, thereby deferring to the universal wrapper set insiderenderElement.tsx.Say goodbye to this:
And hello to this:
As with all things interactives related there's always a chance of unexpected and horrifying side effects, though looking at several pieces locally with this change applied I'm hopeful this is just a nice little improvement.