Skip to content

chore(psyqo): spu - add base_alloc_addr for convenience#1997

Open
Forceh91 wants to merge 1 commit intogrumpycoders:mainfrom
Forceh91:main
Open

chore(psyqo): spu - add base_alloc_addr for convenience#1997
Forceh91 wants to merge 1 commit intogrumpycoders:mainfrom
Forceh91:main

Conversation

@Forceh91
Copy link
Copy Markdown
Contributor

@Forceh91 Forceh91 commented Apr 4, 2026

Added psyqo::SPU::BASE_ALLOC_ADDR for convenience to help people with the spuAddress on psyqo::SPU::dmaWrite

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0bcd08f1-7e85-4b09-904d-eaab4c91cb13

📥 Commits

Reviewing files that changed from the base of the PR and between c2ad3b2 and a99eeab.

📒 Files selected for processing (1)
  • src/mips/psyqo/spu.hh

📝 Walkthrough

Walkthrough

Added a new public static constant BASE_ALLOC_ADDR with value 0x1010 to the SPU class in the header file. This compile-time constant is positioned alongside existing constants like NO_FREE_CHANNEL and BASE_SAMPLE_RATE. No functional logic or control flow modifications were introduced.

Changes

Cohort / File(s) Summary
SPU Constants
src/mips/psyqo/spu.hh
Added public static constant BASE_ALLOC_ADDR (uint16_t = 0x1010) to the SPU class.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

size/S

Suggested reviewers

  • nicolasnoble

Poem

🐰 A constant springs forth, 0x1010 bright,
In SPU's realm where memory takes flight,
Base allocation, a path newly defined,
One little hop leaves the old ways behind! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding a new convenience constant BASE_ALLOC_ADDR to the SPU class. It is concise, clear, and specific about the modification.
Description check ✅ Passed The description is directly related to the changeset, explaining the purpose of the new constant (BASE_ALLOC_ADDR) and its intended use with the spuAddress parameter of dmaWrite.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant