Websocket Support#77
Conversation
|
This looks pretty solid. I'll give this a run when I'm at my desktop tomorrow. I really appreciate contributions like this out of the blue! |
|
Aiden I need to see a dank meme before I can approve this work. |
| "noUnusedLocals": true /* Report errors on unused locals. */, | ||
| "noUnusedParameters": true /* Report errors on unused parameters. */, | ||
| "noUnusedLocals": false /* Report errors on unused locals. */, | ||
| "noUnusedParameters": false /* Report errors on unused parameters. */, |
|
|
||
| # modified by aiden for websocket support. | ||
| # will hopefully be deleted soon when merged in to upstream | ||
|
|
You're welcome. We needed to mock websockets any way and it didn't make sense two sets of mocking infra
It will take a long time to find a suitably dank meme for a PR of this calibre. Now I can see there is an appetite to upstream this I will more than likely clean this up on my next 10pc day next friday |
|
@HamishDixon morley has aske me to remind you that you are a flim-flam |
|
@aidenscott2016 please remind Morley that I am his dad. |
aidenscott2016
force-pushed
the
websocket
branch
from
ad9a419 to
75aa057
Compare
aidenscott2016
force-pushed
the
websocket
branch
from
75aa057 to
8df38c7
Compare
|
@grug this is ready for merge |
|
I'm going to have to run this stuff locally and see how it all works as I feel like people can get pretty fancy with their websocket setups so I want to see how this stands up against some weird configurations. |
Co-authored-by: Dave Cooper <dave@davecooper.dev>
|
thumbs up emoji |
|
@aidenscott2016 are you still okay with all of this? I'm thinking of merging and releasing today :) |
|
@grug ye man merge it |
5 participants
We have had a need to mock a WS server at OVO using this library. This work implements that.
See tests for usage