feat(build): Preserve error from ready() as Status source#2614
Open
jrose-signal wants to merge 1 commit into
Open
feat(build): Preserve error from ready() as Status source#2614jrose-signal wants to merge 1 commit into
jrose-signal wants to merge 1 commit into
Conversation
Client APIs await ready() on their inner Service before sending anything, but currently any errors from ready() are flattened to a message on an Unknown Status. Changing to Status::from_error would be a more drastic change and lose the custom message, but we can at least save the original error as an Error::source.
Author
|
Hm, the Clippy failure is my fault (and easy enough to fix), but the Windows one certainly isn't. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client APIs await
ready()on their inner Service before sending anything, but currently any errors fromready()are flattened to a message on anUnknownStatus. Changing toStatus::from_errorwould be a more drastic change and lose the custom message, but we can at least save the original error as anError::source.This comes up when e.g. a connection is no longer accepting new requests; getting a plain
Unknownback for that is rather inscrutable, and doubly so when not logging the message out of an abundance of caution around user data.Still to do: add a test, because I wasn't sure where it should live. But I'm happy to write it! I'm also not sure if this qualifies as a semantically-breaking change that can't go into v0.14.x.