test: improve MirroringInterceptor test coverage (cancel, multi-message, null checks, failure isolation)#12821
Closed
atulsingh1501 wants to merge 11 commits into
Closed
Conversation
Add a reachability fence in shutdown() and shutdownNow() to ensure the wrapper is not garbage collected while shutdown logic is executing. This prevents a race condition when using directExecutor() where a warning could be logged despite a proper shutdown. Fixes grpc#12641
This adds a fire-and-forget interceptor that mirrors Unary and Streaming traffic to a secondary channel without blocking the primary call. Headers are copied and propagated safely, and the secondary call respects the lifecycle (halfClose, cancel) of the primary stream. Addresses the Java ClientInterceptor proposal discussed in grpc#12448
…mechbro/grpc-java into feature/grpc-mirroring-unary
…ll checks, and failure isolation
Author
|
Hi team! Could a maintainer please run /gcbrun to trigger the CI tests? |
Author
|
Hi team! The 4 failing tests appear to be pre-existing failures |
Author
|
Closing this in favor of contributing directly to themechbro's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes coverage gap in #12721 (MirroringInterceptor PoC).
The existing test only covered the basic unary mirroring scenario,
leaving coverage at ~62% (CI requires 80%).
This PR adds 5 new test cases:
Relates to: #12448