Open
Conversation
Collaborator
|
Hey! Thanks a ton! These are useful changes.Regarding your question about subgroups vs subtopics vs topics: As far as I'm aware, the API itself is inconsistent in how it references topics. (It's been a moment, I'm not entirely sure. Someone would have to verify that for me). Obviously the thing to do in the technical docs would be to stick with whatever is most consistent within the API itself — similar to the "guilds" vs "servers" discrepancy in the discord API. Unfortunately I'm unavailable to review and merge PRs right now, but Peter should be here sooner or later. You can also hit other maintainers up in the Groupme group or email me personally at ***@***.***
|
Author
|
Hey, @not-so-smart! When will you be available to review this PR? If you're not available please let me know who might be. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change includes the following changes:
Also, I've noticed that topics are called subtopics in some places and subgroups in others. What would be the correct language? I know in terms of endpoint paths
subgroupsmight be more correct. But I also seetopicas a returned field inGET /groups/:group_id/subgroups/:subgroup_id.