Skip to content

Small Improvements#43

Open
jordangeorge wants to merge 7 commits intogroupme-js:masterfrom
jordangeorge:improvements-2026-march
Open

Small Improvements#43
jordangeorge wants to merge 7 commits intogroupme-js:masterfrom
jordangeorge:improvements-2026-march

Conversation

@jordangeorge
Copy link
Copy Markdown

@jordangeorge jordangeorge commented Mar 5, 2026

This change includes the following changes:

  • An important note regarding subgroups/subtopics.
    • I think this is good to have because I didn't know subgroups were basically groups. I thought it wouldn't be possible for me to get events from a subgroup until I just tried on a whim to use the group endpoints for subgroups/topics.
  • An updated README.md for accurate linking
  • Typo and capitalization corrections for clarity

Also, I've noticed that topics are called subtopics in some places and subgroups in others. What would be the correct language? I know in terms of endpoint paths subgroups might be more correct. But I also see topic as a returned field in GET /groups/:group_id/subgroups/:subgroup_id.

@AlureonTheVirus
Copy link
Copy Markdown
Collaborator

AlureonTheVirus commented Mar 5, 2026 via email

@jordangeorge
Copy link
Copy Markdown
Author

Hey, @not-so-smart! When will you be available to review this PR? If you're not available please let me know who might be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants