replace lstrip with removeprefix in WSGI path lookup#313
Open
GibberishIT wants to merge 1 commit intogrindsa:masterfrom
Open
replace lstrip with removeprefix in WSGI path lookup#313GibberishIT wants to merge 1 commit intogrindsa:masterfrom
GibberishIT wants to merge 1 commit intogrindsa:masterfrom
Conversation
When starting a WSGI Server with the Directory:url_prefix configured: If the url_prefix contains characters from the requested path, too much is stripped from the path and some URLs become unreachable. https://docs.python.org/3/library/stdtypes.html#str.lstrip "The chars argument is not a prefix; rather, all combinations of its values are stripped." removeprefix is python 3.9+ but should be safer. For check: "/directory".lstrip("/devel-base")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When starting a WSGI Server with the Directory:url_prefix configured: If the url_prefix contains characters from the requested path, too much is stripped from the path and some URLs become unreachable.
https://docs.python.org/3/library/stdtypes.html#str.lstrip
"The chars argument is not a prefix; rather, all combinations of its values are stripped."
removeprefix is python 3.9+ but should be safer. For check:
"/directory".lstrip("/devel-base")