refactor: focus docs on tailnet access and terminal sessions#134
Merged
Conversation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+198
to
+199
| cached.initialCommandSent = false | ||
| cached.runId = runId |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
- Add missing comma in docs/index.tsx feature list - Only reset initialCommandSent when runId changes to prevent duplicate command sends on terminal remount
Comment on lines
+757
to
+761
| key={`agent-${name}`} | ||
| workspaceName={name!} | ||
| initialCommand={terminalMode.command} | ||
| runId={terminalMode.command} | ||
| /> |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
New sessions now get a timestamp-based runId to prevent cache collisions when starting multiple sessions with the same agent type.
- Remove unused handleSessionId callback - Update tests to expect "New Session" instead of "New Chat" - Update tests to check for terminal UI instead of chat UI
Comment on lines
538
to
+541
|
|
||
| const handleNewChat = (agentType: AgentType = 'claude-code') => { | ||
| setProjectPathOverride(undefined) | ||
| if (agentType === 'claude-code' || agentType === 'opencode') { | ||
| setChatMode({ type: 'chat', agentType }) | ||
| } else { | ||
| setChatMode({ type: 'terminal', command: 'codex' }) | ||
| } | ||
| const handleNewSession = (agentType: AgentType = 'claude-code') => { | ||
| const sessionId = `${agentType}-${Date.now()}` | ||
| setTerminalMode({ type: 'terminal', command: agentType, runId: sessionId }) |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Comment on lines
+539
to
+541
| const handleNewSession = (agentType: AgentType = 'claude-code') => { | ||
| const sessionId = `${agentType}-${Date.now()}` | ||
| setTerminalMode({ type: 'terminal', command: agentType, runId: sessionId }) |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Store the unique runId in URL search params so it survives component re-renders, preventing duplicate session initialization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing