feat: oidc domain registration and verification #7745
Conversation
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-hive/laboratory |
1.0.0-alpha-20260309110356-3a87327b103ed9b6d9d43630fbe030caf5623ede |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/render-laboratory |
1.0.0-alpha-20260309110356-3a87327b103ed9b6d9d43630fbe030caf5623ede |
npm ↗︎ unpkg ↗︎ |
hive |
9.7.0-alpha-20260309110356-3a87327b103ed9b6d9d43630fbe030caf5623ede |
npm ↗︎ unpkg ↗︎ |
Summary of ChangesHello @n1ru4l, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant feature for OIDC integrations, enabling organizations to register and verify domains. This enhancement aims to improve the user experience by allowing automatic user provisioning and bypassing email verification for users from verified domains. It involves comprehensive changes across the backend, including database schema updates, new API endpoints, and a dedicated data store, as well as a complete overhaul of the frontend SSO settings interface to expose these new capabilities. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
💻 Website PreviewThe latest changes are available as preview in: https://pr-7745.hive-landing-page.pages.dev |
There was a problem hiding this comment.
Code Review
This pull request introduces OIDC domain registration and verification, a significant new feature. However, critical flaws exist in the authorization logic, where OIDC integration IDs are incorrectly used instead of organization IDs for permission checks, potentially breaking the feature for legitimate users. Additionally, a database integrity issue was identified in the domain creation logic due to a missing required column in an INSERT statement. Other issues include a broken GraphQL query, typos, and a faulty regex for domain validation. Please review the detailed comments for suggestions on how to fix these issues.
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tag: |
aa30811 to
b8eda49
Compare
c2835ae to
65286f5
Compare
310c1c9 to
b36594d
Compare
fc23191 to
427e602
Compare
0a1e931 to
594c1d1
Compare
Background
Closes #7735
Description
This PR addresses the following things:
buzzcheck.devA full run through of the PR can be found on on this internal Slack video: https://guild-oss.slack.com/archives/CAY2119MX/p1772221874651489?thread_ts=1772218438.245559&cid=CAY2119MX
Originally I wanted to have #7763 as part of the scope of this PR. But it got a bit bigger, so I will do that in a follow up PR.
Here are some screenshots of the functionality, but I recommend to watch the video instead.
Rollout Strategy
This change is fully backwards-compatible. I will probably manually create records for our known and trusted enterprise users to spare them some time running through the DNS challenge. In case we would need to rollback the pre-existing functionality continues to work. The only regression would be that some people need to verify their email again.
Checklist