Skip to content

Improve Submission Navigation perf: Context split SubmissionSidebar#199

Merged
msaroufim merged 2 commits intomainfrom
more-perf
Feb 25, 2026
Merged

Improve Submission Navigation perf: Context split SubmissionSidebar#199
msaroufim merged 2 commits intomainfrom
more-perf

Conversation

@Jack-Khuu
Copy link
Collaborator

The navigation in the sidebar is still slower than we'd like, so this PR improves this by splitting up the static components (ActionsContext) from the dynamic content (StateContext). This reduces the components that have to pay attention to the dynamic parts of the sidebar

Also sprinkles in some memo() to reduce re-render

Spot testing render times gives us ~35% speedup

Before

Sidebar  Navigation render 202 3ms

After

sidebar, Navigation render 135 5as

@msaroufim msaroufim temporarily deployed to kernelboard-more-perf-ubgrxfd0 February 24, 2026 22:13 Inactive
@yangw-dev
Copy link
Collaborator

fyi, for long code loading, maybe it's good to add rendering loading element during the rendering

@yangw-dev yangw-dev self-requested a review February 24, 2026 23:31
@msaroufim msaroufim merged commit aeb8425 into main Feb 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants