Skip to content

Add missing Welsh personalisations for confirmation email#2112

Merged
chao-xian merged 1 commit into
mainfrom
welsh-confirmation
May 20, 2026
Merged

Add missing Welsh personalisations for confirmation email#2112
chao-xian merged 1 commit into
mainfrom
welsh-confirmation

Conversation

@chao-xian
Copy link
Copy Markdown
Contributor

What problem does this pull request solve?

A couple were missed from #2083

The Notify template will also need updating

Trello card: https://trello.com/c/NLqWmwvf/2894-update-confirmation-emails-to-cater-for-new-welsh-form-submissions

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

Copy link
Copy Markdown
Contributor

@stephencdaly stephencdaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a failing test but otherwise looks good and still works locally. Will approve once the test is fixed.

@chao-xian chao-xian force-pushed the welsh-confirmation branch from 214eb34 to 76ac54a Compare May 20, 2026 14:44
@github-actions
Copy link
Copy Markdown
Contributor

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2112.submit.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@chao-xian chao-xian added this pull request to the merge queue May 20, 2026
Merged via the queue into main with commit 9e52742 May 20, 2026
3 checks passed
@chao-xian chao-xian deleted the welsh-confirmation branch May 20, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants