Skip to content

Change live/archived pages view for multiple branches#2791

Merged
SamJamCul merged 3 commits into
mainfrom
show-new-routes-in-live-archived-view
May 20, 2026
Merged

Change live/archived pages view for multiple branches#2791
SamJamCul merged 3 commits into
mainfrom
show-new-routes-in-live-archived-view

Conversation

@SamJamCul
Copy link
Copy Markdown
Contributor

@SamJamCul SamJamCul commented May 19, 2026

When a form has the multiple_branches_enabled flag set, the live and archived show pages has a different format to display the routes for a form.

What problem does this pull request solve?

https://trello.com/c/LtIlAUBk/3072-show-new-routes-in-live-archived-view

The live and archived form view shows multiple branch routes appropriately.


Single conditional route

image

Multiple conditional routes

image

Unconditionally go to a page

image

Unconditionally go to the end of the form

image

Fixing the none_of_the_above bug for the current forms as well

before:
image

after:
image

@SamJamCul SamJamCul force-pushed the show-new-routes-in-live-archived-view branch 3 times, most recently from ffbb55f to c3e90a8 Compare May 19, 2026 10:05
@hannahkc
Copy link
Copy Markdown
Contributor

Content in the screenshots looks perfect! thank you.

Comment thread app/controllers/forms/archived_controller.rb Outdated
@SamJamCul SamJamCul force-pushed the show-new-routes-in-live-archived-view branch 4 times, most recently from 00419ee to 1ad7107 Compare May 19, 2026 11:19
SamJamCul added 3 commits May 19, 2026 12:22
When a form has the multiple_branches_enabled flag set, the live and
archived show pages has a different format to display the routes for
a form.
The step_summary_card_service needs to know if the group for a given
form has the multiple_branches_enabled flag set, so it has to be passed
in through the chain of things that make use of it.
When a route uses the none_of_the_above option as its trigger, we need
to display "None of the above" rather than just using the answer_value
for the condition.
@SamJamCul SamJamCul force-pushed the show-new-routes-in-live-archived-view branch from 1ad7107 to 73825d7 Compare May 19, 2026 11:23
@github-actions
Copy link
Copy Markdown

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2791.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@SamJamCul SamJamCul added this pull request to the merge queue May 20, 2026
Merged via the queue into main with commit b11b181 May 20, 2026
3 checks passed
@SamJamCul SamJamCul deleted the show-new-routes-in-live-archived-view branch May 20, 2026 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants