Separate gost89, gosthash, gosthash2012 modules and fix incorrect alignment in gosthash2012 causing potential SEGFAULT #514
Merged
chipitsine merged 2 commits intogost-engine:masterfrom Feb 24, 2026
Conversation
Add tests for gosthash and gosthash2012
Before this commit, the declaration of `union uint512_u` applied 16-byte alignment only to the typedef name, resulting in different alignments: * `union uint512_u` — 8 bytes * `uint512_u` — 16 bytes The implementation in gosthash2012.c assumes 16-byte alignment for the union. When the tag type (`union uint512_u`) was used (e.g., in structures or on the stack), this mismatch could lead to misaligned accesses and SEGFAULT. After this change, 16-byte alignment is applied to the union type itself, so both: * `union uint512_u` * `uint512_u` are consistently 16-byte aligned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR separates modules that do not depend on OpenSSL or the complex gost-core,
as part of addressing #496.
It also adds tests for the
gosthashandgosthash2012modules.Additionally, it fixes incorrect alignment in
gosthash2012that could lead to SEGFAULTs.