Skip to content

feat(ui): adds repo-based collapsible grouping to Issues and PRs tabs#6

Merged
wgordon17 merged 10 commits intogordon-code:mainfrom
wgordon17:roadmap/phase-1/repo-grouping
Mar 24, 2026
Merged

feat(ui): adds repo-based collapsible grouping to Issues and PRs tabs#6
wgordon17 merged 10 commits intogordon-code:mainfrom
wgordon17:roadmap/phase-1/repo-grouping

Conversation

@wgordon17
Copy link
Copy Markdown
Member

Summary

  • Adds collapsible repo-based grouping to IssuesTab and PullRequestsTab, matching ActionsTab's existing pattern
  • Extracts ChevronIcon to shared component, adds hideRepo prop to ItemRow, whole-group pagination with page-boundary splitting
  • Fixes pre-existing issues: inverted workflow sort comparators in api.ts, stale page signal on data shrink, plain-fn reactive accessors upgraded to createMemo, collapsedRepos migrated from createSignal to createStore for per-repo fine-grained reactivity

@wgordon17 wgordon17 force-pushed the roadmap/phase-1/repo-grouping branch from 501f7b5 to 1bed45d Compare March 24, 2026 19:48
Migrates all 3 tabs (ActionsTab, IssuesTab, PullRequestsTab) from
createSignal<Set<string>> to createStore<Record<string, boolean>> for
per-repo fine-grained reactivity. Toggling one repo group no longer
re-evaluates aria-expanded, ChevronIcon rotation, and Show conditions
for all other groups.

Adds 6 new tests: aria-expanded toggle (collapse+re-expand for both
tabs), multi-page pagination, and oversized single-group behavior.
- Extracts groupByRepo, computePageLayout, slicePageGroups to shared generic lib/grouping.ts, eliminating verbatim duplication between IssuesTab and PullRequestsTab

- Wraps pageCount in createMemo, consistent with commit 7749a68

- Inlines pageSize (removes unnecessary createMemo wrapper)

- Adds named isRepoCollapsed accessor in IssuesTab/PullRequestsTab, consistent with ActionsTab pattern

- Changes ChevronIcon sizeClass from createMemo to plain arrow fn, consistent with ItemRow isCompact pattern

- Adds aria-expanded to ActionsTab workflow-level toggle button

- Formats PullRequestsTab FilterChips handlers to multi-line style

- Adds unit tests for grouping boundary cases, PullRequestsTab page-reset, sort-order assertions, and ActionsTab aria-expanded tests
@wgordon17 wgordon17 force-pushed the roadmap/phase-1/repo-grouping branch from 1bed45d to 744cd81 Compare March 24, 2026 20:11
@wgordon17 wgordon17 merged commit 64c3da7 into gordon-code:main Mar 24, 2026
2 checks passed
@wgordon17 wgordon17 deleted the roadmap/phase-1/repo-grouping branch March 25, 2026 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant