feat(auth): migrates from GitHub App to OAuth App#4
Merged
wgordon17 merged 22 commits intogordon-code:mainfrom Mar 24, 2026
Merged
feat(auth): migrates from GitHub App to OAuth App#4wgordon17 merged 22 commits intogordon-code:mainfrom
wgordon17 merged 22 commits intogordon-code:mainfrom
Conversation
- Adds read-only guard to Octokit client (blocks non-GET except POST /graphql) - Fixes _coordinator not nulled on DashboardPage unmount (polling died after navigation) - Validates token before navigating in OAuthCallback (clears auth on failure) - Deduplicates onCleanup/destroy in poll coordinator (onCleanup delegates to destroy) - Merges two onAuthCleared registrations into single callback in DashboardPage - Uses top-level import type for DashboardData instead of inline import() - Simplifies localStorage init guard in auth.ts (drops typeof, keeps optional chaining) - Adds tests: destroy(), reentrancy guard, validateToken=false, OPTIONS 404, cold-start
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
repo read:org notifications)