Skip to content

chore: removes WAF bypass token (BFM disabled) #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wgordon17 merged 1 commit into from
Mar 28, 2026
Merged

chore: removes WAF bypass token (BFM disabled) #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ jobs:
run: node scripts/verify-csp-hash.mjs
- name: WAF smoke tests
run: pnpm test:waf
env:
WAF_BYPASS_TOKEN: ${{ secrets.WAF_BYPASS_TOKEN }}
- run: pnpm run build
env:
VITE_GITHUB_CLIENT_ID: ${{ vars.VITE_GITHUB_CLIENT_ID }}
Expand Down
10 changes: 1 addition & 9 deletions scripts/waf-smoke-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,6 @@ BASE="https://gh.gordoncode.dev"
PASS=0
FAIL=0

# When WAF_BYPASS_TOKEN is set (CI), send a header that a Cloudflare WAF rule
# uses to skip Bot Fight Mode for this request. Without it (local dev), requests
# pass through normally since residential IPs aren't challenged.
BYPASS=()
if [[ -n "${WAF_BYPASS_TOKEN:-}" ]]; then
BYPASS=(-H "X-CI-Bypass: ${WAF_BYPASS_TOKEN}")
fi

assert_status() {
local expected="$1" actual="$2" label="$3"
if [[ "$actual" == "$expected" ]]; then
Expand All @@ -34,7 +26,7 @@ assert_status() {
}

fetch() {
curl -s -o /dev/null -w "%{http_code}" "${BYPASS[@]}" "$@"
curl -s -o /dev/null -w "%{http_code}" "$@"
}

# ============================================================
Expand Down
Loading