feat(notifications): adds toast and drawer notification system#11
Merged
wgordon17 merged 14 commits intogordon-code:mainfrom Mar 25, 2026
Merged
Conversation
…everity and read state
…ves circular import
… and adds aria-modal
…aned toasts on dismiss
… fixes responsive width, caches matchMedia, clears state on logout
- wraps mutedSources in createSignal for proper SolidJS reactivity - swaps markAllAsRead/setDrawerOpen order so unread highlights render - removes dead errors prop from tab components and DashboardStore - adds type="button" to all notification drawer and toast buttons - adds createMemo for sorted notifications, classList consistency - adds 8 new tests: muting, pruning, aria-expanded, reset, cycling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary