fix: migrate to new Darwin SDK pattern in nix flake#154
Conversation
|
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the project's Nix flake to accommodate a breaking change in the Nixpkgs Darwin SDK. By migrating to the new Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the Nix flake configuration to align with the new Darwin SDK pattern in nixpkgs. The change correctly replaces the deprecated darwin.apple_sdk.frameworks.Security with apple-sdk. This is a necessary fix to ensure the package continues to build correctly on Darwin systems. The change is accurate and well-contained.
a573f0d to
0e0f9b7
Compare
Replace removed `darwin.apple_sdk.frameworks.Security` with `apple-sdk`, following the nixpkgs Darwin SDK migration (NixOS/nixpkgs#354146).
0e0f9b7 to
f501816
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
=======================================
Coverage 55.19% 55.19%
=======================================
Files 38 38
Lines 13166 13166
=======================================
Hits 7267 7267
Misses 5899 5899 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Replace removed
darwin.apple_sdk.frameworks.Securitywithapple-sdk, following the nixpkgs Darwin SDK migration (NixOS/nixpkgs#354146).Checklist:
AGENTS.mdguidelines (no generatedgoogle-*crates).cargo fmt --allto format the code perfectly.cargo clippy -- -D warningsand resolved all warnings.pnpx changeset) to document my changes.