test: add coverage for helper dispatch and service alias resolution#111
test: add coverage for helper dispatch and service alias resolution#111Bortlesboat wants to merge 1 commit intogoogleworkspace:mainfrom
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
🦋 Changeset detectedLatest commit: 9340f25 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
I have signed the Google CLA — please re-check. |
Change your Claude settings to make this easier for Google CLA. {
"attribution": {
"commit": "",
"pr": ""
}
} |
- Add tests for get_helper() in helpers/mod.rs: all known services, unknown services, case sensitivity, script alias, helper_only default - Add tests for resolve_service() edge cases: all aliases exhaustively, case sensitivity, empty string, error message content, duplicate alias detection
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
==========================================
+ Coverage 56.21% 56.41% +0.19%
==========================================
Files 38 38
Lines 13853 13914 +61
==========================================
+ Hits 7788 7849 +61
Misses 6065 6065 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
helpers::get_helper()— previously untestedservices::resolve_service()test coverage with edge casesNew Tests
helpers/mod.rstest_get_helper_known_services— all 11 service names return a helpertest_get_helper_unknown_returns_none— unknown/empty/wrong-case returns Nonetest_get_helper_script_alias— both "script" and "apps-script" worktest_helper_default_not_helper_only— default trait impl returns falseservices.rstest_resolve_service_all_aliases— exhaustively tests every alias in SERVICEStest_resolve_service_case_sensitive— "Drive" and "GMAIL" should failtest_resolve_service_empty_string— empty string should failtest_resolve_service_error_lists_known_services— error message includes available servicestest_no_duplicate_aliases— ensures no alias appears twice in SERVICESTest plan
cargo testpasses (CI will verify)cargo clippy -- -D warningsclean (CI will verify)