fix(ios): use NSInteger for setFollowingPerspective parameter type#538
Open
christian-apollo wants to merge 1 commit intogooglemaps:mainfrom
Open
fix(ios): use NSInteger for setFollowingPerspective parameter type#538christian-apollo wants to merge 1 commit intogooglemaps:mainfrom
christian-apollo wants to merge 1 commit intogooglemaps:mainfrom
Conversation
The perspective parameter was declared as `double` but immediately cast to `NSInteger`. Using `NSInteger` directly avoids a lossy implicit floating-point-to-integer conversion and matches the expected enum type. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The perspective parameter was declared as
doublebut immediately cast toNSInteger. UsingNSIntegerdirectly avoids a lossy implicit floating-point-to-integer conversion and matches the expected enum type.Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.
Pre-launch Checklist