feat(generator): add extra allowed modules that will not be removed from the monorepo if they are present

[chingor13]

This is needed for the auth-library and sdk-platform-java migration into the monorepo

[gemini-code-assist]

Summary of Changes

Hello @chingor13, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a crucial enhancement to the monorepo's pom.xml generation script. It enables the inclusion of specific Java modules, identified by an explicit allowlist, into the root pom.xml, even if they do not adhere to the standard java- prefix naming convention. This change directly supports the integration of existing projects like auth-library and sdk-platform-java into the monorepo, streamlining their migration process.

Highlights

• Enhanced Module Discovery: The __search_for_java_modules function was updated to include a new module_allowlist. This allows specific modules, not following the java- prefix convention, to be recognized and included in the root pom.xml generation.
• Monorepo Migration Support: Explicitly added 'google-auth-library-java' and 'sdk-platform-java' to the module_allowlist, facilitating their migration and integration into the monorepo's build structure.

Changelog

• hermetic_build/library_generation/utils/pom_generator.py
  • Introduced a module_allowlist set to define specific Java modules that should always be included.
  • Modified the __search_for_java_modules function to check if a subdirectory's name is present in the module_allowlist.
  • Added debug print statements to generate_root_pom and __search_for_java_modules for better visibility during module discovery.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces an allowlist for modules to prevent them from being removed during POM generation, which is a necessary change for upcoming repository migrations. The implementation is sound, but I have a few suggestions to improve the code quality. These include removing leftover debugging statements, adhering to Python's standard naming conventions for constants, and simplifying some of the new conditional logic. I've provided specific code suggestions for these points in the review comments.

[sonarqubecloud]

Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sonarqubecloud]

Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud