fix: support list[pydantic.BaseModel] in response.parsed type annotation : Issue #886#906
Open
Adewale-1 wants to merge 6 commits intogoogleapis:mainfrom
Open
fix: support list[pydantic.BaseModel] in response.parsed type annotation : Issue #886#906Adewale-1 wants to merge 6 commits intogoogleapis:mainfrom
Adewale-1 wants to merge 6 commits intogoogleapis:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@Adewale-1 looks like you will have to sign the contributor agreement for this PR to be accepted. |
Collaborator
|
Hey @Adewale-1 |
Resolved merge conflicts in google/genai/types.py while preserving the list[pydantic.BaseModel] support in the parsed field type annotation.
5797bc6 to
12e18cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #886 by adding support for
list[pydantic.BaseModel]in theparsedfield's type annotation ofGenerateContentResponse.Problem
Currently, when using
response_schema=list[SomeModel]in the API call, the code functionally works (returning a list of model objects), but mypy type checking fails because the type annotation doesn't include the possibility of a list of pydantic models.This requires developers to use explicit type casting (as shown in PR #886), which reduces confidence in unit tests and type safety.
Solution
Added
list[pydantic.BaseModel]to the Union type in theparsedfield type annotation.Testing
Added comprehensive tests in:
Tests verify both runtime behavior and mypy type checking compatibility.