docs: fix incorrect pageSize() reference in Pager.page docstring#2502
Open
aryanmotgi wants to merge 1 commit into
Open
docs: fix incorrect pageSize() reference in Pager.page docstring#2502aryanmotgi wants to merge 1 commit into
aryanmotgi wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hi @aryanmotgi, Thanks for reaching out us! Some checks have failed, please resolve the conflicts.z Thanks |
The docstring referenced pageSize() (camelCase method call) but the actual attribute is page_size (snake_case property).
aryanmotgi
force-pushed
the
fix/pager-page-size-docstring
branch
from
0e20cc2 to
c69208d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docstring for
_BasePager.pagereferencespageSize()(camelCase, as if it were a method), but the actual public attribute is thepage_sizeproperty (snake_case, no parens).This is purely a documentation fix — a one-line update in
google/genai/pagers.pyto point readers to the correct attribute name.