fix: handle boolean additionalProperties in _filter_to_supported_schema#2459
Open
mahesh-sadupalli wants to merge 1 commit into
Open
fix: handle boolean additionalProperties in _filter_to_supported_schema#2459mahesh-sadupalli wants to merge 1 commit into
mahesh-sadupalli wants to merge 1 commit into
Conversation
Add type check to return non-dict values (like booleans) as-is. Fixes AttributeError when MCP tools have 'additionalProperties: false' in their schema, common in Pydantic-generated schemas used by FastMCP. Fixes googleapis#2393
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
if not isinstance(schema, dict): return schemaguard at the top of_filter_to_supported_schema()AttributeError: 'bool' object has no attribute 'items'when MCP tools haveadditionalProperties: falsein their JSON schema (common in Pydantic-generated schemas used by FastMCP)Fixes #2393
Test plan
additionalProperties: falsewithout crashing