chore: librarian update image pull request: 20260226T220740Z#1303
chore: librarian update image pull request: 20260226T220740Z#1303
Conversation
…prod/images-prod/python-librarian-generator@sha256:160860d189ff1c2f7515638478823712fa5b243e27ccc33a2728669fa1e2ed0c
|
One or more libraries have failed to generate, please review PR description for a list of failed libraries. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on maintenance and updates for the Librarian generation process. It updates the default Python version to 3.14 and upgrades the underlying Docker image used for generating client libraries. A significant part of this change involves removing the existing Highlights
Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request, which updates the librarian generator image, appears to have failed during generation for the google-cloud-bigtable library. This failure has resulted in the deletion of a significant number of files, effectively removing the google.cloud.bigtable_admin client and its related modules. This is a critical issue that breaks the package. The pull request should be reverted or fixed by addressing the generation failure and re-adding the deleted files.
I am having trouble creating individual review comments. Click here to see my feedback.
google/cloud/bigtable_admin/init.py (1-455)
This file, along with the entire google.cloud.bigtable_admin and google.cloud.bigtable_admin_v2 packages, has been deleted. This appears to be an unintended consequence of a failed generation process, as noted in the pull request description ('Generation failed for google-cloud-bigtable'). Removing these core package files is a critical issue and will break the library. These files need to be restored.
feat: update image to us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:160860d189ff1c2f7515638478823712fa5b243e27ccc33a2728669fa1e2ed0c
Generation failed for