Skip to content

feat(tool/cmd/migrate): hardcode showcase library version#5932

Merged
zhumin8 merged 1 commit into
googleapis:mainfrom
zhumin8:fix-showcase-migrate-version
May 8, 2026
Merged

feat(tool/cmd/migrate): hardcode showcase library version#5932
zhumin8 merged 1 commit into
googleapis:mainfrom
zhumin8:fix-showcase-migrate-version

Conversation

@zhumin8
Copy link
Copy Markdown
Contributor

@zhumin8 zhumin8 commented May 8, 2026

The library version for showcase is hardcoded to 0.0.1-SNAPSHOT in Java migration config to ensure valid snapshot versioning. Tests are updated to reflect this expectation. This needs to be hardcoded because in migrate script, we source versions from versions.txt, but this recent change googleapis/google-cloud-java#13030 removed showcase tracking from it.

For #5731

The library version for showcase is hardcoded to 0.0.1-SNAPSHOT in Java migration config to ensure valid snapshot versioning. Tests are updated to reflect this expectation.
@zhumin8 zhumin8 marked this pull request as ready for review May 8, 2026 17:58
@zhumin8 zhumin8 requested a review from a team as a code owner May 8, 2026 17:58
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the Java migration tool to explicitly assign the version "0.0.1-SNAPSHOT" to the showcase library during the configuration building process. The corresponding test case in java_test.go has also been updated to include this version field. I have no feedback to provide as there were no review comments to evaluate.

@zhumin8 zhumin8 merged commit d55f2e7 into googleapis:main May 8, 2026
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants