fix(internal/librarian/java): pass gapic option generate-version-java to gapic generator#5923
Merged
Merged
Conversation
… to gapic generator
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
zhumin8
force-pushed
the
java-gapic-new-flag
branch
from
12c25fd to
e5b7998
Compare
Contributor
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the Java GAPIC generation process to include the "generate-version-java" option, which ensures the generation of the Version.java file. Corresponding test cases in internal/librarian/java/generate_test.go were updated to include this new option in their expected output. I have no feedback to provide.
sofisl
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the
generate-version-javaflag toresolveGAPICOptionsingenerate.goto enable generation ofVersion.javaby default. This is a new flag introduced in googleapis/google-cloud-java#12955, intended to pass uniformly for all open source generation.Fix #5820